Loosen dependency version requirements for improved packaging compati…#161
Merged
Conversation
…bility Allow broader version ranges for dependencies to improve compatibility with system-provided packages: - Set tui-input to >=0.14.0 - Use >= constraints for other dependencies
|
Speaking for Fedora packaging - this seems to have been well-intentioned, but will just cause brokenness. Most of our tooling and best practices assume that dependency ranges use Open-ended version ranges like the ones introduced in this PR are unusual, and will likely just cause problems as soon as any of those dependencies release a new major version that breaks API (or worse, behaviour). |
Owner
Author
|
@decathorpe thanks for the feedback. I haven't cut 0.7.1 yet because I was on the fence about this too. Would you mind reviewing this? #176 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…bility
Allow broader version ranges for dependencies to improve compatibility with system-provided packages: