chore(ci): run build and release on 20.04#48
Merged
Conversation
Pin to the 2020 LTS to compile against glibc 2.31 and hence support a wider range of glibc versions than the current 2.35+ provided by the ubuntu-22.04 runner. This is the oldest glibc supported out of the box from GitHub Runners: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
Owner
|
@dnwe thanks. Out of curiosity, what distro are you running? Do you normally install bpftop from the release artifact? (so not building from source). |
Contributor
Author
|
It was a pool of 20.04 workers that I wanted to use it on and yes would normally grab and distribute the release binary for them. I basically made a fork just to get GH actions to quickly build me a compatible binary and attach it to releases so I didn’t have to use my local toolchain to build. At that point it felt useful to contribute back as a suggestion for compatibility purposes |
Owner
|
Got it. I will cut a new release soon so that you can retire your custom release pipeline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin to the 2020 LTS to compile against glibc 2.31 and hence support a wider range of glibc versions than the current 2.35+ provided by the ubuntu-22.04 runner.
This is the oldest glibc supported out of the box from GitHub Runners: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories