Build info extractor Maven plugin should not fire Maven lifecycle event callbacks on its own

[facewindu]

The build-info-extractor-maven3-plugin fires Maven callbacks on its own when the deploy goal is executed. See here

I don't understand why this is needed. I also think this is a terrible idea as this break some core assumptions.
For instance, using your artifactory-maven-plugin-example project, we see that Maven will then emit two ProjectStarted events for the top-level-project.
This can break listeners that assume (rightly in my opinion) that only one of this projectStarted event should be fired for a given project.

The Gradle Enterprise Maven extension is one of such listeners, and we'd really want to avoid catering from this problem on our side.

[facewindu]

Hi @yahavi
what do you think of this ?
I'll work tomorrow on providing a PR that removes those calls, and hopefully this won't break anything in your logic. But maybe you already know it will, and can tell me why ?

Basically, removing

eventCatapult.fire( ExecutionEvent.Type.SessionStarted, session, null )
eventCatapult.fire( ExecutionEvent.Type.ProjectStarted, session, null )

[github-actions]

This issue has been marked as stale due to 6 months of inactivity. As part of our effort to address every issue properly, please feel free to remove the stale label or keep this issue active by leaving a comment. Otherwise, it will be closed in 7 days

[github-actions]

This issue was closed due to 7 days of inactivity after being marked as stale. Feel free to reopen it if it remains relevant.