Skip to content

Frogbot.sh used creds when not needed, breaking the working #1339

@t794104

Description

@t794104

Describe the bug

Since 2.34.0 the 'download_to()' function was rewritten. It no longer checks if ${REMOTE_PATH} is set and just uses 'JF_USER' in the curl command.

This breaks the use case that we want to download Frogbot executable from JFrog directly but do have out own Artifactory that needs authentication. So JF_URL, JF_USER and JF_PASSWORD are set but only needed for the executable, not Frogbot.sh

Current behavior

But skipping the REMOTE_PATH check the current Frogbot.sh uses the JF_USER/JF_PASSWORD for the Jfrog which gives a 401. Which is correct as the user doesn't exists on release.jfrog.io.

Reproduction steps

No response

Expected behavior

No response

JFrog Frogbot version

2.34.0

Package manager info

NA

Git provider

GitHub

JFrog Frogbot configuration yaml file

none

Operating system type and version

x86 linux

JFrog Xray version

NA

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions