Skip uploading results to GH if no information#1269
Merged
Conversation
attiasas
added
bug
github-actions
Bot
removed
the
safe to test
attiasas
added
the
safe to test
github-actions
Bot
removed
the
safe to test
meirjfrog
approved these changes
Apr 23, 2026
attiasas
added
the
safe to test
github-actions
Bot
removed
the
safe to test
attiasas
added
the
safe to test
github-actions
Bot
removed
the
safe to test
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix(github): skip Code Scanning SARIF upload when scan results have no information
Description
GitHub’s Code Scanning SARIF upload endpoint returns HTTP 400 with Invalid SARIF document: Empty sarif file provided when the payload is effectively empty (for example SARIF with
"runs": []). That can happen when no SCA components are found and there is nothing meaningful to report, which led Frogbot to attempt an upload anyway and surface a warning/failure despite there being no findings.This change short-circuits
UploadRepoSarifResultsToGithubSecurityTabwhenscanResultsis nil orscanResults.HasInformation()is false, so Frogbot does not generate or upload SARIF in those cases and logs that the GitHub Security Tab upload was skipped.Changes
utils/utils.go: At the start ofUploadRepoSarifResultsToGithubSecurityTab, return early (with an info log) when there is no scan information, beforegenerateFrogbotSarifReportand the GitHub upload run.