Adding Signature Validation When getFrogbot.sh Downloads Frogbot#1312
Merged
Conversation
orto17
changed the title
orto17
added
the
safe to test
github-actions
Bot
removed
the
safe to test
attiasas
reviewed
May 25, 2026
| echo "Uploading $exeName to $destPath ..." | ||
| jf rt u "./$exeName" "$destPath" | ||
| sha256sum "$exeName" >"${exeName}.sha256" | ||
| jf rt u "./${exeName}.sha256" "$pkgPath/$version/$pkg/${exeName}.sha256" |
Contributor
There was a problem hiding this comment.
why do we need to upload sha file?? Artifactory already resolve and manage this (as far as I can see)
we can ask for the sha value
we should only verify at download.
On upload you can calculate the sha, upload
attiasas
requested changes
May 26, 2026
Contributor
attiasas
left a comment
attiasas
left a comment
There was a problem hiding this comment.
See comments, I suggest remove new script or remember to upload and download it
attiasas
approved these changes
May 27, 2026
Comment on lines
+182
to
+201
| file_md5=$(local_md5 "${FILE_NAME}") | ||
| file_sha1=$(local_sha1 "${FILE_NAME}") | ||
| if [ "${file_md5}" != "${remote_md5}" ] || [ "${file_sha1}" != "${remote_sha1}" ]; then | ||
| echo "Checksum verification failed." >&2 | ||
| echo "Remote md5=${remote_md5} sha1=${remote_sha1}" >&2 | ||
| echo "Local md5=${file_md5} sha1=${file_sha1}" >&2 | ||
| rm -f "${FILE_NAME}" | ||
| exit 1 | ||
| fi | ||
|
|
||
| if [ -n "${remote_sha256}" ]; then | ||
| file_sha256=$(local_sha256 "${FILE_NAME}") | ||
| if [ "${file_sha256}" != "${remote_sha256}" ]; then | ||
| echo "Checksum verification failed." >&2 | ||
| echo "Remote sha256=${remote_sha256}" >&2 | ||
| echo "Local sha256=${file_sha256}" >&2 | ||
| rm -f "${FILE_NAME}" | ||
| exit 1 | ||
| fi | ||
| fi |
Contributor
There was a problem hiding this comment.
split/merge (why sha256 is not with the others/why the others are grouped and sha256 not...)
orto17
added
the
safe to test
github-actions
Bot
removed
the
safe to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Artifactory checksum verification for Frogbot release artifacts using GetRemoteFileDetails, so uploaded and downloaded binaries are validated against server-side MD5/SHA1/SHA256 headers.
Introduce release/verifyartifact for post-upload verification in buildAndUpload.sh, and extend getFrogbot.sh with download-time checksum validation and support for custom repo layouts (e.g. ecosys-frogbot/v2).