Skip to content

Fix nested dependencies/plugins issue in Maven#266

Merged
omerzi merged 23 commits intojfrog:devfrom
omerzi:fix-nested-deps-maven
Mar 26, 2023
Merged

Fix nested dependencies/plugins issue in Maven#266
omerzi merged 23 commits intojfrog:devfrom
omerzi:fix-nested-deps-maven

Conversation

@omerzi
Copy link
Member

@omerzi omerzi commented Mar 14, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@omerzi omerzi added bug Something isn't working safe to test Approve running integration tests on a pull request labels Mar 14, 2023
@omerzi omerzi requested review from eyalbe4 and yahavi March 14, 2023 14:26
@omerzi omerzi temporarily deployed to frogbot March 14, 2023 14:26 — with GitHub Actions Inactive
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 14, 2023
@github-actions
Copy link
Contributor

What is Frogbot?

1 similar comment
@github-actions
Copy link
Contributor

What is Frogbot?

tmpProjectPath, cleanup := testdatautils.CreateTestProject(t, projectPath)
defer cleanup()
assert.NoError(t, os.Chdir(tmpProjectPath))
func() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reson for creating this function here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defer inside a loop

@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Mar 26, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 26, 2023
@github-actions
Copy link
Contributor

What is Frogbot?

@omerzi omerzi merged commit b273c10 into jfrog:dev Mar 26, 2023
@omerzi omerzi deleted the fix-nested-deps-maven branch March 26, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants