Skip to content

Add a static badge for Frogbot#299

Merged
eyalbe4 merged 29 commits intojfrog:devfrom
eyalbe4:frogbot-badge
Apr 12, 2023
Merged

Add a static badge for Frogbot#299
eyalbe4 merged 29 commits intojfrog:devfrom
eyalbe4:frogbot-badge

Conversation

@eyalbe4
Copy link
Copy Markdown
Contributor

@eyalbe4 eyalbe4 commented Apr 11, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Added a new svg badge to the images directory of the frogbot repository.
  • Added the badge to the README of Frogbot.
  • Added a new section to the documentation, describing how the badge can be added to the README file of a repository.

image

@eyalbe4 eyalbe4 added the new feature Automatically generated release notes label Apr 11, 2023
@eyalbe4 eyalbe4 requested a review from yahavi April 11, 2023 15:59
@EyalDelarea
Copy link
Copy Markdown
Contributor

EyalDelarea commented Apr 11, 2023 •
edited
Loading

badge

green-badge

I've actually made a badge with frogbot's icon , what do you think?

@eyalbe4
Copy link
Copy Markdown
Contributor Author

eyalbe4 commented Apr 11, 2023

Wow. Looks amazing @EyalDelarea!
Would you like to add a commit to this PR with your improved badge?

@EyalDelarea
Copy link
Copy Markdown
Contributor

EyalDelarea commented Apr 11, 2023

Wow. Looks amazing @EyalDelarea! Would you like to add a commit to this PR with your improved badge?

maybe need to fix the updated badge xml

@eyalbe4
Copy link
Copy Markdown
Contributor Author

eyalbe4 commented Apr 11, 2023

Looks great @EyalDelarea!
If you don't have comments and can approve this PR, I'll go ahead and merge it.

@eyalbe4 eyalbe4 merged commit ef72693 into jfrog:dev Apr 12, 2023
@eyalbe4 eyalbe4 deleted the frogbot-badge branch May 6, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yahavi yahavi Awaiting requested review from yahavi

1 more reviewer

@EyalDelarea EyalDelarea EyalDelarea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

new feature Automatically generated release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eyalbe4 @EyalDelarea