Skip to content

Conversation

@attiasas
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

When scan fails or issue occur, projectIssues *issues.ScansIssuesCollection can sometime be nil that caused PANIC

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xf77e89]
goroutine 1 [running]:
github.com/jfrog/frogbot/v2/scanpullrequest.auditPullRequest(0xc0003db208, {0x1580e40, 0xc0003a8ba0})
	/var/opt/jfrog/pipelines/data/release_frogbot/runs/4285355/steps/Release/31033311/dependencyState/resources/frogbotGit/scanpullrequest/scanpullrequest.go:167 +0x4e9
github.com/jfrog/frogbot/v2/scanpullrequest.scanPullRequest(0xc0003db208, {0x1580e40, 0xc0003a8ba0})
	/var/opt/jfrog/pipelines/data/release_frogbot/runs/4285355/steps/Release/31033311/dependencyState/resources/frogbotGit/scanpullrequest/scanpullrequest.go:96 +0x330
github.com/jfrog/frogbot/v2/scanpullrequest.(*ScanPullRequestCmd).Run(0xc00003bef0?, {0xc0003db208, 0x1, 0x1}, {0x1580e40, 0xc0003a8ba0}, 0xc000524c60)
	/var/opt/jfrog/pipelines/data/release_frogbot/runs/4285355/steps/Release/31033311/dependencyState/resources/frogbotGit/scanpullrequest/scanpullrequest.go:48 +0x2d9
main.Exec({0x1568d60, 0x1f72c60}, {0x138a743, 0x11})
	/var/opt/jfrog/pipelines/data/release_frogbot/runs/4285355/steps/Release/31033311/dependencyState/resources/frogbotGit/commands.go:103 +0x46d
main.GetCommands.func1(0xc000343b80?)
	/var/opt/jfrog/pipelines/data/release_frogbot/runs/4285355/steps/Release/31033311/dependencyState/resources/frogbotGit/commands.go:34 +0x2c
github.com/urfave/cli/v2.(*Command).Run(0xc000392160, 0xc000343b80, {0xc00032b6e0, 0x1, 0x1})
	/home/frogger/go/pkg/mod/github.com/urfave/cli/v2@v2.27.4/command.go:276 +0x7e2
github.com/urfave/cli/v2.(*Command).Run(0xc000392840, 0xc000343a40, {0xc0000340c0, 0x2, 0x2})
	/home/frogger/go/pkg/mod/github.com/urfave/cli/v2@v2.27.4/command.go:269 +0xa65
github.com/urfave/cli/v2.(*App).RunContext(0xc0001e2400, {0x1571980, 0x1f72c60}, {0xc0000340c0, 0x2, 0x2})
	/home/frogger/go/pkg/mod/github.com/urfave/cli/v2@v2.27.4/app.go:333 +0x5a5
github.com/urfave/cli/v2.(*App).Run(...)
	/home/frogger/go/pkg/mod/github.com/urfave/cli/v2@v2.27.4/app.go:307
main.ExecMain()
	/var/opt/jfrog/pipelines/data/release_frogbot/runs/4285355/steps/Release/31033311/dependencyState/resources/frogbotGit/main.go:25 +0x13b
main.main()
	/var/opt/jfrog/pipelines/data/release_frogbot/runs/4285355/steps/Release/31033311/dependencyState/resources/frogbotGit/main.go:14 +0x18

@attiasas attiasas added bug Something isn't working safe to test Approve running integration tests on a pull request labels Jan 19, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 19, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jan 19, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 19, 2025
@github-actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


@attiasas attiasas merged commit c88a3a1 into jfrog:dev Jan 19, 2025
46 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants