Skip to content

Conversation

@reshmifrog
Copy link
Contributor

@reshmifrog reshmifrog commented Dec 2, 2025

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the master branch.
  • I used gofmt for formatting the code before submitting the pull request.

  • Problem: The jf rt curl command was fragile , it was incorrectly treating the boolean flags like -L, -v, -s as if they needed a value, causing it to skip the API path.
  • Solution: We created a list of all curl flags that are boolean flags. When parsing, if a flag is in this list, we don't skip the next argument. If it's not in the list, we assume it needs a value and skip the next argument. For combined flags like -Lo, we scan each character - once we find a flag that needs a value, anything after it is treated as its inline value(e.g -Lotest.txt).

@reshmifrog reshmifrog added the bug Something isn't working label Dec 2, 2025
@bhanurp bhanurp self-requested a review December 5, 2025 10:20
@github-actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


@reshmifrog reshmifrog merged commit f8481d1 into jfrog:master Dec 10, 2025
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working safe-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants