Skip to content

Conversation

@attiasas
Copy link
Contributor

@attiasas attiasas commented Jan 5, 2025

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Before, we added the analytics pixel with space and at the suffix. It was not a valid Markdown content according to Github and its parser removed this hidden link.

After testing, we can inject it as a prefix to the content and it will display (UI will be fixed in the future)

image

@attiasas attiasas added ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request labels Jan 5, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 5, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jan 5, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 5, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jan 6, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 6, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jan 6, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 6, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jan 6, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 6, 2025
@github-actions
Copy link

github-actions bot commented Jan 6, 2025

👍 Frogbot scanned this pull request and did not find any new security issues.


@github-actions
Copy link

github-actions bot commented Jan 6, 2025

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/jfrog/jfrog-cli-security/utils/results/conversion/sarifparser 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils/results/output 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/jfrog/jfrog-cli-security/utils/results/conversion/sarifparser/sarifparser.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/results/output/securityJobSummary.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/jfrog/jfrog-cli-security/utils/results/conversion/sarifparser/sarifparser_test.go

@attiasas attiasas merged commit 1fff830 into jfrog:dev Jan 6, 2025
56 checks passed
@attiasas attiasas deleted the gh_sarif_link_prefix branch January 6, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore for release Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants