Skip to content

Conversation

@attiasas
Copy link
Contributor

@attiasas attiasas commented Jan 12, 2025

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

We were overriding the technology to empty value, not showing in display since the actual technology was not passed.

@attiasas attiasas added the bug Something isn't working label Jan 12, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jan 12, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 12, 2025
@attiasas attiasas changed the title Pass Technology to SCA scan Pass Technology of SCA scan Jan 12, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jan 19, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 19, 2025
@github-actions
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/jfrog/jfrog-cli-security/commands/audit 0.00% (ø)
github.com/jfrog/jfrog-cli-security/commands/audit/sca 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/jfrog/jfrog-cli-security/commands/audit/sca/common.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/commands/audit/scarunner.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@github-actions
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


@attiasas attiasas merged commit e8c6c63 into jfrog:dev Jan 20, 2025
9 checks passed
@attiasas attiasas deleted the pass_tech_sca branch January 20, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants