Conversation
eranturgeman
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix using wrapper for Maven dependency tree
NewMavenDepTreeManagerwas constructing a newDepTreeParamswith onlyServerandDepsRepo, silently droppingUseWrapper(andUseIncludedBuilds). This meantRunMvnCmdalways executedmvneven when the project uses a Maven wrapper (./mvnw), causing failures on systems without a global Maven installation.The fix passes the full
paramsobject toNewDepTreeManagerso all fields are preserved.Changes
sca/bom/buildinfo/technologies/java/mvn.go: Pass the originalparamstoNewDepTreeManagerinstead of constructing a partial copy with onlyServerandDepsRepo.sca/bom/buildinfo/technologies/java/mvn_test.go:TestNewMavenDepTreeManagerPreservesAllParams— unit test verifying allDepTreeParamsfields propagate correctly through the constructor.TestMavenWrapperTreesto passUseWrapper: trueso it actually exercises the./mvnwcode path.TestDepTreeWithDedicatedCacheto passUseWrapper: truesince it also uses the wrapper test project.devbranch.go vet ./....go fmt ./....