-
Notifications
You must be signed in to change notification settings - Fork 277
Rt cmd migration #2936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rt cmd migration #2936
Conversation
3c783db to
3ccbe9d
Compare
3ccbe9d to
a9fc8b2
Compare
a9fc8b2 to
3896122
Compare
3896122 to
1e3c6e8
Compare
1e3c6e8 to
b99b9cb
Compare
b99b9cb to
92a0881
Compare
92a0881 to
5110877
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't went over all of it yet, a few questions / suggestions by now:
- Why wasn't
artifactory/cli.gomoved as a whole? That way we wouldn't need to handle merging a namespace (appendNewCommands). - Please delete in this PR everything that was moved (docs, utils, flags, etc) to avoid duplications.
@RobiNino This was done to avoid moving build commands, since build commands are depended on jfrog-cli-security and as we know jfrog-cli-security is already using jfrog-cli-artifactory, we do not want to introduce a cyclic dependency here. |
devbranch.go vet ./....go fmt ./....depends on :-