Skip to content

Conversation

@fluxxBot
Copy link
Contributor

@fluxxBot fluxxBot commented Mar 25, 2025

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

depends on :-

  1. Rt cmd migration jfrog-cli-artifactory#58
  2. Rt cmd migration jfrog-cli-core#1370

@fluxxBot fluxxBot added the safe to test Approve running integration tests on a pull request label Mar 25, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 25, 2025
@fluxxBot fluxxBot added the safe to test Approve running integration tests on a pull request label Mar 25, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 25, 2025
@fluxxBot fluxxBot added the safe to test Approve running integration tests on a pull request label Mar 26, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 26, 2025
@fluxxBot fluxxBot added the safe to test Approve running integration tests on a pull request label Mar 26, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 26, 2025
@fluxxBot fluxxBot added the safe to test Approve running integration tests on a pull request label Mar 26, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 26, 2025
@fluxxBot fluxxBot added the safe to test Approve running integration tests on a pull request label Mar 27, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 27, 2025
@fluxxBot fluxxBot added the safe to test Approve running integration tests on a pull request label Mar 27, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 27, 2025
@fluxxBot fluxxBot added the safe to test Approve running integration tests on a pull request label Mar 27, 2025
@fluxxBot fluxxBot requested a review from bhanurp March 27, 2025 10:56
@fluxxBot fluxxBot marked this pull request as ready for review March 27, 2025 10:56
@fluxxBot fluxxBot requested a review from RobiNino March 27, 2025 11:11
@fluxxBot fluxxBot added the safe to test Approve running integration tests on a pull request label Mar 28, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 28, 2025
Copy link
Contributor

@RobiNino RobiNino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't went over all of it yet, a few questions / suggestions by now:

  1. Why wasn't artifactory/cli.go moved as a whole? That way we wouldn't need to handle merging a namespace (appendNewCommands).
  2. Please delete in this PR everything that was moved (docs, utils, flags, etc) to avoid duplications.

@fluxxBot
Copy link
Contributor Author

fluxxBot commented Apr 1, 2025

Haven't went over all of it yet, a few questions / suggestions by now:

  1. Why wasn't artifactory/cli.go moved as a whole? That way we wouldn't need to handle merging a namespace (appendNewCommands).
  2. Please delete in this PR everything that was moved (docs, utils, flags, etc) to avoid duplications.

@RobiNino This was done to avoid moving build commands, since build commands are depended on jfrog-cli-security and as we know jfrog-cli-security is already using jfrog-cli-artifactory, we do not want to introduce a cyclic dependency here.

@fluxxBot fluxxBot added the safe to test Approve running integration tests on a pull request label Apr 3, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 3, 2025
@fluxxBot fluxxBot added the safe to test Approve running integration tests on a pull request label Apr 7, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 7, 2025
@fluxxBot fluxxBot merged commit 6bd77d7 into jfrog:dev Apr 7, 2025
65 of 66 checks passed
@fluxxBot fluxxBot added the ignore for release Automatically generated release notes label Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore for release Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants