Add common --format flag support#3454
Merged
Merged
Conversation
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
ehl-jf
added
the
safe to test
RemiBou
reviewed
Apr 24, 2026
Comment on lines
+227
to
+228
| case coreformat.Json: | ||
| return printConfigShowJSON(configs) |
Contributor
There was a problem hiding this comment.
do we have a way to make this a common function so sub command creator dont worry about it ?
RemiBou
approved these changes
Apr 24, 2026
| return nil | ||
| // getTokenOutputFormat returns the requested output format, defaulting to json | ||
| // to preserve backward-compatible behaviour (the command always emitted JSON). | ||
| func getTokenOutputFormat(c *cli.Context) (coreformat.OutputFormat, error) { |
Contributor
There was a problem hiding this comment.
make it common in cli context ?
Contributor
Author
There was a problem hiding this comment.
cli.Context is in urfave/cli. But it is doable in plugins that use our own encapsulation of context.
ehl-jf
force-pushed
the
JGC-471-format-support
branch
from
5e1d2fa to
7bf5ae2
Compare
ehl-jf
added
safe to test
ehl-jf
force-pushed
the
JGC-471-format-support
branch
from
7bf5ae2 to
3b95d48
Compare
ehl-jf
added
safe to test
ehl-jf
force-pushed
the
JGC-471-format-support
branch
from
3b95d48 to
fdbab1d
Compare
ehl-jf
added
safe to test
ehl-jf
force-pushed
the
JGC-471-format-support
branch
from
fdbab1d to
9b2e6bd
Compare
ehl-jf
added
safe to test
ehl-jf
force-pushed
the
JGC-471-format-support
branch
from
9b2e6bd to
af54846
Compare
ehl-jf
added
safe to test
ehl-jf
force-pushed
the
JGC-471-format-support
branch
from
af54846 to
83d204e
Compare
ehl-jf
added
safe to test
ehl-jf
force-pushed
the
JGC-471-format-support
branch
from
83d204e to
25b9864
Compare
ehl-jf
added
safe to test
ehl-jf
force-pushed
the
JGC-471-format-support
branch
from
25b9864 to
fe21cb8
Compare
ehl-jf
added
safe to test
ehl-jf
force-pushed
the
JGC-471-format-support
branch
from
fe21cb8 to
5af9d26
Compare
ehl-jf
added
safe to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
masterbranch.go vet ./....go fmt ./....