Add usage report for jf api#3479
Merged
Merged
Conversation
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
RemiBou
approved these changes
May 11, 2026
7afbd7d to
ef63fae
Compare
ef63fae to
5002589
Compare
5002589 to
9a2b75d
Compare
9a2b75d to
091e376
Compare
091e376 to
eb2464d
Compare
eb2464d to
b7d9f32
Compare
b7d9f32 to
9069354
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires
jf apiinto the existing usage-reporting and metrics pipeline used by other top-level commands:commands.CollectMetrics("api", …).commands.ReportUsagein a goroutine alongside the HTTP call, with a--timeout-bounded wait andrecoverso reporting can't crash or hangjf api.reportUsageFnindirection to make the reporting path unit-testable without HTTP.jfrog-cli-coreto pick up theCollectMetricsAPI.Test plan
Six new unit tests in
general/api/cli_test.gocovering metrics collection, the timeout-bounded wait helper, the disabled-reporting env var, panic recovery, slow-reporter timeout cutoff, and fast-reporter happy path.masterbranch.go vet ./....go fmt ./....