Skip to content

RTECO-992 - Fix uv build command build-info and update jfrog-cli-artifactory dependency#3485

Merged
agrasth merged 1 commit into
jfrog:masterfrom
agrasth:fix/uv-build-command-buildinfo
May 14, 2026
Merged

RTECO-992 - Fix uv build command build-info and update jfrog-cli-artifactory dependency#3485
agrasth merged 1 commit into
jfrog:masterfrom
agrasth:fix/uv-build-command-buildinfo

Conversation

@agrasth
Copy link
Copy Markdown
Contributor

@agrasth agrasth commented May 13, 2026

Problem

Three UV tests were failing after jfrog-cli-artifactory PR #438 was merged:

  • TestUvBuild"[]" should have 1 item(s), but has 0 (no module in build-info)
  • TestUvArtifactTypeIsExtensionShould NOT be empty, but was []
  • TestUvCustomModuleShould NOT be empty, but was []

PR #438 skipped build-info entirely for jf uv build, but the tests expected at least a module to exist.

Fix

jfrog-cli-artifactory (PR #449)

Restored build-info collection for jf uv build following Maven's convention for non-deploy goals:

  • Module and dependencies are recorded
  • Artifacts are cleared (nothing is uploaded to Artifactory by uv build)

uv_test.go

TestUvArtifactTypeIsExtension was checking artifact types from jf uv build — but since build no longer records artifacts (consistent with TestUvBuild's existing assertion), the test is updated to verify artifact types via jf uv publish instead.

Changes

  • go.mod / go.sum: updated jfrog-cli-artifactory to pick up the fix
  • uv_test.go: TestUvArtifactTypeIsExtension now runs build then publish before checking artifact types

@agrasth agrasth added the safe to test Approve running integration tests on a pull request label May 13, 2026
@agrasth agrasth force-pushed the fix/uv-build-command-buildinfo branch from 8dbb1a0 to 5b96a4e Compare May 14, 2026 07:20
@agrasth agrasth added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels May 14, 2026
…factory dependency

- Update jfrog-cli-artifactory to pick up fix for jf uv build build-info
  (restores module+dependencies, clears artifacts following Maven convention)
- Fix TestUvArtifactTypeIsExtension: verify artifact types via jf uv publish
  instead of jf uv build since build uploads nothing to Artifactory
@agrasth agrasth force-pushed the fix/uv-build-command-buildinfo branch from 5b96a4e to 4ff81f4 Compare May 14, 2026 08:04
@agrasth agrasth added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels May 14, 2026
@agrasth agrasth merged commit f67fa8c into jfrog:master May 14, 2026
88 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Approve running integration tests on a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants