Skip to content

Add new Xray graph scan API support #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
talarian1 merged 12 commits into from
Sep 30, 2021
Merged

Add new Xray graph scan API support #21

talarian1 merged 12 commits into from
Sep 30, 2021

Conversation

@talarian1
Copy link
Contributor

@talarian1 talarian1 commented Sep 26, 2021

No description provided.

@talarian1 talarian1 requested a review from eyalbe4 September 26, 2021 08:01
yahavi
yahavi reviewed Sep 27, 2021
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like ImpactPathImpl class is missing. Can you please add it?

eyalbe4
eyalbe4 suggested changes Sep 29, 2021
View reviewed changes
yahavi
yahavi requested changes Sep 30, 2021
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please looks at my inline comments.
Also, I saw some lines with compiler warnings, such as "Private field 'name' is never assigned" and "Private field 'licenseName' is never assigned". I'd add a suppression above this field, or a above the class declaration.
One last thing - I think that GraphImpl class requires a test.

@yahavi
Copy link
Member

yahavi commented Sep 30, 2021

One more thing - I noticed in some cases @JsonProperty above getters and setters. I think they should be deleted, because there are already @JsonProperty above the interface's values.

talarian1 and others added 2 commits September 30, 2021 17:37
@talarian1 @yahavi
Apply suggestions from code review
d86d9ff 
Co-authored-by: Yahav Itzhak <yahavi@users.noreply.github.com>
@talarian1
Format files
a1c9b72
yahavi
yahavi requested changes Sep 30, 2021
View reviewed changes
talarian1 and others added 2 commits September 30, 2021 18:47
@talarian1
Update build-info version to 2.31.0
f1560a1
@talarian1 @yahavi
Apply suggestions from code review
45b4d01 
Co-authored-by: Yahav Itzhak <yahavi@users.noreply.github.com>
@talarian1 talarian1 merged commit 8c3f6ea into jfrog:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yahavi yahavi yahavi requested changes

+1 more reviewer

@eyalbe4 eyalbe4 eyalbe4 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@talarian1 @yahavi @eyalbe4