Skip to content

chore: cleanup labels on flux resources#1254

Merged
jfroy merged 1 commit into
mainfrom
flux-cleanup
May 4, 2026
Merged

chore: cleanup labels on flux resources#1254
jfroy merged 1 commit into
mainfrom
flux-cleanup

Conversation

@jfroy
Copy link
Copy Markdown
Owner

@jfroy jfroy commented May 4, 2026

Summary by CodeRabbit

  • Chores
    • Streamlined Kubernetes resource metadata configurations
    • Enhanced endpoint health monitoring setup for improved observability

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 582ebcae-7a94-4976-b4ee-8b3370e8c6f2

📥 Commits

Reviewing files that changed from the base of the PR and between a40d547 and 020af4b.

📒 Files selected for processing (2)
  • kubernetes/apps/flux-system/instance/ks/httproute.yaml
  • kubernetes/apps/flux-system/instance/ks/podmonitor.yaml
💤 Files with no reviewable changes (2)
  • kubernetes/apps/flux-system/instance/ks/httproute.yaml
  • kubernetes/apps/flux-system/instance/ks/podmonitor.yaml

📝 Walkthrough

Walkthrough

This PR updates metadata in two Kubernetes resource manifests within the flux-system configuration. The HTTPRoute replaces labels with a Gatus endpoint monitoring annotation, while the PodMonitor removes standard Kubernetes application labels.

Changes

Flux System Resource Metadata Updates

Layer / File(s) Summary
HTTPRoute Metadata
kubernetes/apps/flux-system/instance/ks/httproute.yaml
Replaces metadata.labels with gatus.home-operations.com/endpoint annotation configured to monitor for 404 status conditions.
PodMonitor Metadata
kubernetes/apps/flux-system/instance/ks/podmonitor.yaml
Removes app.kubernetes.io/* standard labels from metadata.labels.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Labels trimmed, annotations bloom,
Gatus watches every room,
Clean YAML, neat and tight,
Kubernetes config, crisp and right! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: cleanup labels on flux resources' directly and clearly describes the main change—removing labels from flux system resources (HTTPRoute and PodMonitor).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch flux-cleanup

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

--- kubernetes/apps/flux-system/instance/ks Kustomization: flux-system/flux-instance HTTPRoute: flux-system/github-webhook

+++ kubernetes/apps/flux-system/instance/ks Kustomization: flux-system/flux-instance HTTPRoute: flux-system/github-webhook

@@ -2,14 +2,12 @@

 apiVersion: gateway.networking.k8s.io/v1
 kind: HTTPRoute
 metadata:
   annotations:
     gatus.home-operations.com/endpoint: 'conditions: ["[STATUS] == 404"]'
   labels:
-    app.kubernetes.io/name: github-webhook
-    app.kubernetes.io/part-of: flux
     kustomize.toolkit.fluxcd.io/name: flux-instance
     kustomize.toolkit.fluxcd.io/namespace: flux-system
   name: github-webhook
   namespace: flux-system
 spec:
   hostnames:
--- kubernetes/apps/flux-system/instance/ks Kustomization: flux-system/flux-instance PodMonitor: flux-system/flux

+++ kubernetes/apps/flux-system/instance/ks Kustomization: flux-system/flux-instance PodMonitor: flux-system/flux

@@ -1,15 +1,11 @@

 ---
 apiVersion: monitoring.coreos.com/v1
 kind: PodMonitor
 metadata:
   labels:
-    app.kubernetes.io/component: metrics
-    app.kubernetes.io/instance: flux
-    app.kubernetes.io/name: flux
-    app.kubernetes.io/part-of: flux
     kustomize.toolkit.fluxcd.io/name: flux-instance
     kustomize.toolkit.fluxcd.io/namespace: flux-system
   name: flux
   namespace: flux-system
 spec:
   jobLabel: app.kubernetes.io/instance

@jfroy jfroy merged commit 31f28eb into main May 4, 2026
7 checks passed
@jfroy jfroy deleted the flux-cleanup branch May 4, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant