Actividad 01 (Palíndromos)#20
Open
guillermoar26 wants to merge 3 commits intojgsogo:actividadesfrom
Open
Conversation
Author
|
@jgsogo Hola Javier, no tengo ni idea dónde está el fallo. En Qt me reconoce "amad a la dama" como palíndromo y aquí no 🤔 |
jgsogo
requested changes
Feb 27, 2021
Owner
jgsogo
left a comment
jgsogo
left a comment
There was a problem hiding this comment.
Tiene pinta de que te pasa lo mismo que a David y que le he comentado aquí #18 (review). Tienes una función remove_blanks que no estás utilizando... quizá en tus pruebas con el Qt Creator no estás probando con ninguna frase como amad a la dama, que es un palíndromo si le eliminas los espacios.
Como puedes ver, ése es justo el ejemplo que falla en los tests de tu pull-request: https://github.com/jgsogo/eda/pull/20/checks?check_run_id=1941356744
/home/runner/work/eda/eda/actividad01/tests/test_palindrome.cpp:25: FAILED:
REQUIRE( is_palindrome("amad a la dama") == true )
with expansion:
false == true
jgsogo
force-pushed
the
actividades
branch
4 times, most recently
from
1ab93ef to
e638cb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.