Conversation
Add encoding/base64 import that was missing, causing build failures. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- MSI: Fix WiX v4 syntax - use Condition attribute instead of inner text - RPM: Disable build-id links for Go binaries to suppress warning Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Use version variable instead of file version binding (Go binaries lack version resources) - Remove WixUI extension dependency for simpler build - Fix duplicate file reference issue - Consolidate service install into main executable component Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Remove accidentally committed serverkit-agent.exe - Add .gitignore to prevent committing binaries Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Convert paths to absolute before changing directories - Use --target flag for cross-architecture builds (arm64 on x86_64) - Remove hardcoded BuildArch from spec (let --target handle it) - Fix permission denied error when creating output directory Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Changed the agent service image from 'serverkit/agent:latest' to 'jhd3197/serverkit-agent:latest' to use the updated repository.
Change Docker Hub repository from serverkit/agent to jhd3197/serverkit-agent to match the actual Docker Hub account. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the agent release/build pipeline so Linux (deb/rpm), Windows (MSI), and Docker images build and publish reliably, while also cleaning up accidentally committed build artifacts.
Changes:
- Fix RPM packaging to support cross-arch builds and avoid output path/permission issues.
- Simplify the WiX v4 MSI definition and switch it to an explicit
Versionvariable. - Update Docker image references and clean up repository artifacts (.gitignore + remove committed
.exe).
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
agent/packaging/rpm/build.sh |
Makes RPM builds more robust (absolute paths, --target, _build_id_links none, output dir handling). |
agent/packaging/msi/Product.wxs |
Simplifies MSI definition; uses $(var.Version) and removes UI/custom-action complexity and duplicate file reference. |
agent/internal/agent/agent.go |
Adds missing encoding/base64 import required by existing base64 encode/decode usage. |
agent/docker-compose.yml |
Updates compose to use the new Docker image repository. |
agent/.gitignore |
Prevents committing agent build artifacts and common binary outputs. |
VERSION |
Bumps version number. |
.github/workflows/agent-release.yml |
Updates Docker tags/docs to jhd3197/serverkit-agent and aligns release instructions accordingly. |
agent/serverkit-agent.exe |
Removes accidentally committed binary from the repo. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the agent release workflow to successfully build and publish packages for all platforms
(Linux, Windows, Docker).
Build Fixes
encoding/base64import in agent code--targetflagduplicate file reference
Repository Cleanup
serverkit-agent.exebinary.gitignorefor agent build artifactsDocker
jhd3197/serverkit-agent