Conversation
Expanded the uninstall process to explicitly list all components and directories that will be removed, including nginx configs and ServerKit-specific data. Added informational messages and ensured nginx is reloaded if necessary. Clarified that system packages are not removed automatically.
There was a problem hiding this comment.
Pull request overview
This PR enhances the uninstall script with comprehensive cleanup steps and user-friendly informational messages. It provides transparency about what will be removed during uninstallation and ensures proper cleanup of nginx configurations.
Changes:
- Added detailed pre-uninstall message listing all components that will be removed
- Implemented removal of ServerKit configuration directories (/etc/serverkit, /var/serverkit)
- Added nginx site configuration cleanup with safe reload logic
- Included post-uninstall notice clarifying that system packages are not automatically removed
- Version bumped from 1.2.73 to 1.2.74
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| serverkit | Enhanced uninstall function with detailed informational messages, nginx config cleanup, and comprehensive directory removal |
| VERSION | Version increment from 1.2.73 to 1.2.74 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| echo " - Frontend Docker container and images" | ||
| echo " - Installation directory ($INSTALL_DIR)" | ||
| echo " - Configuration (/etc/serverkit)" | ||
| echo " - App data (/var/serverkit)" |
There was a problem hiding this comment.
The directory /var/lib/serverkit is being removed (line 523) but is not mentioned in the informational list above. This directory stores uptime history data and should be included in the list for completeness. Consider adding a line like "- Data files (/var/lib/serverkit)" to the informational message.
| echo " - App data (/var/serverkit)" | |
| echo " - App data (/var/serverkit)" | |
| echo " - Data files (/var/lib/serverkit)" |
Expanded the uninstall process to explicitly list all components and directories that will be removed, including nginx configs and ServerKit-specific data. Added informational messages and ensured nginx is reloaded if necessary. Clarified that system packages are not removed automatically.