Skip to content

[#293] Added 'SupportedImageHandler' for supported_image module.#307

Merged
AlexSkrypnyk merged 2 commits intomasterfrom
feature/supported-image
Apr 16, 2026
Merged

[#293] Added 'SupportedImageHandler' for supported_image module.#307
AlexSkrypnyk merged 2 commits intomasterfrom
feature/supported-image

Conversation

@AlexSkrypnyk
Copy link
Copy Markdown
Collaborator

Iterates on #294 by @chrisolof. Thank you for the contribution!

Summary

  • Added SupportedImageHandler for the supported_image Drupal contrib module (resolves Add field handler for Supported Image fields #293).
  • The handler extends AbstractHandler and mirrors the existing ImageHandler logic, adding support for the extra fields specific to the supported_image module: caption_value, caption_format, attribution_value, and attribution_format.
  • Fixed string concatenation to use single quotes for Drupal coding standards compliance.

Changes

  • src/Drupal/Driver/Fields/Drupal8/SupportedImageHandler.php - new field handler class for supported_image field type.

Test plan

  • PHPUnit test suite: 36/36 OK (verified locally).
  • Manually test by setting a supported_image field value via Behat/DrupalDriver on a Drupal site with the supported_image module enabled and confirm the field is populated correctly including caption and attribution sub-fields.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 16, 2026

Warning

Rate limit exceeded

@AlexSkrypnyk has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 53 minutes and 42 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 53 minutes and 42 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f79d6a84-c261-4524-b349-a09b7800901c

📥 Commits

Reviewing files that changed from the base of the PR and between 0f4c9e0 and 4eac9dc.

📒 Files selected for processing (1)
  • src/Drupal/Driver/Fields/Drupal8/SupportedImageHandler.php
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/supported-image

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/supported-image branch from 85f40e9 to 4eac9dc Compare April 16, 2026 09:17
@AlexSkrypnyk AlexSkrypnyk merged commit d85cc50 into master Apr 16, 2026
6 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/supported-image branch April 16, 2026 22:25
@AlexSkrypnyk AlexSkrypnyk added this to the 2.5 milestone Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add field handler for Supported Image fields

2 participants