[#192] Allowed 'LinkHandler' to accept named field properties.#311
[#192] Allowed 'LinkHandler' to accept named field properties.#311AlexSkrypnyk merged 2 commits intomasterfrom
Conversation
… field properties. Co-authored-by: Christopher O. Caldwell <chrisolof@gmail.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 23 minutes and 30 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
LinkHandler::expand()to accept named field properties (title,uri,options) in addition to the existing numeric index format ([0],[1],[2]).??), so both formats remain fully supported without breaking existing behaviour.optionskey (named or positional) is passed throughparse_str()only when present, and defaults to an empty array to satisfyUnroutedUrlAssembler::assemble().Changes
src/Drupal/Driver/Fields/Drupal8/LinkHandler.php- refactoredexpand()to support named keys alongside numeric indices.Test plan
title,uri,options) is correctly expanded.titleanduri(nooptions) expands without errors.Closes #192.