Added 'NameHandler' for the Name module with tests.#322
Conversation
…dule with tests. Co-authored-by: Derek Laventure <derek@consensus.enterprises>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 15 minutes and 31 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Iterates on #269 by @sensespidey. Thank you for the contribution!
Summary
NameHandlerfor the Name module, properly extendingAbstractHandlerrather than implementingFieldHandlerInterfacedirectly.title,given,middle,family,generational, andcredentials."Family, Given"), named array keys, and positional (numeric index) array keys.NameHandlerTestwith a data provider covering all input formats and multi-value scenarios.Changes
src/Drupal/Driver/Fields/Drupal8/NameHandler.php- new handler.tests/Drupal/Tests/Driver/NameHandlerTest.php- unit tests.Test plan
"Doe, John"mapsfamilyandgivencorrectly.givenisnull).given,family,middle, etc.) pass through as-is.title,given,middle,family,generational,credentials.composer test.