Removed Drupal 6 and 7 support and bumped composer constraints for 3.x.#336
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 10 minutes and 20 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (23)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Code coverage (threshold: 35%) Per-class coverage |
1 participant
Part of #312
Summary
Drops all Drupal 6 and 7 code (core classes, field handlers, specs, and tests), raises
composer.jsonconstraints to require PHP 8.2+, Drupal 10 or 11, and updated Symfony packages. Expands the CI matrix from 5 to 10 entries so that each PHP/Drupal combination is now tested under bothlowestandnormaldependency resolutions, mirroring the Drupal Extension project's CI pattern. UpdatesREADME.mdto reflect thatmasteris now the active 3.x development branch while maintenance of the 2.x line moves to the new2.xbranch.Changes
Removed legacy code
src/Drupal/Driver/Cores/Drupal6.phpandDrupal7.php.src/Drupal/Driver/Fields/Drupal6/andFields/Drupal7/(11 handler files).tests/Drupal/Tests/Driver/Drupal7FieldHandlerTest.phpand the D7-onlyFieldHandlerAbstractTestBase.php.spec/Drupal/Driver/Cores/Drupal6Spec.phpandDrupal7Spec.php.Simplified version detection
DrupalDriver::detectMajorVersion(): removed D6/D7 bootstrap paths (/modules/system/system.module,/includes/bootstrap.inc) and the< 8mapping branch. Now throws an explicitBootstrapExceptionwhen Drupal < 10 is detected.DrupalDriver::readVersionConstant(): removed the legacy globalVERSIONconstant fallback (D6/D7 only); now relies solely on\Drupal::VERSION.Tooling
rector.php: removed the now-orphaned skip entry forDrupal7FieldHandlerTest.php.phpunit.xml.dist: removed all D6/D7<exclude>entries from<source>.composer.jsonconstraint bumpsphp:>=7.4->^8.2.drupal/core-utility,drupal/core-composer-scaffold,drupal/core-recommended:^8.4 || ^9 || ^10 || ^11->^10 || ^11.symfony/dependency-injection,symfony/process: dropped^2.x/^3.x/^4.4; now^6.4 || ^7.symfony/phpunit-bridge:^6.1->^6.4 || ^7.dms/phpunit-arraysubset-asserts:^0.4.0 || ^0.5.0->^0.5.0.phpspec/phpspec: dropped^2.0/^4.0/^6.1; now^7.5 || dev-main.phpunit/phpunit:^6.0 || ^7.0 || ^9 || ^10->^9.6 || ^10 || ^11.conflict.drupal/coreblock (>=8.0 <9.3).extra.branch-alias.dev-masterto3.0.x-dev.CI matrix
testsjob matrix from 5 to 10 entries: each PHP/Drupal combo now runs bothdeps: lowestanddeps: normal(mirrors Drupal Extension's CI pattern).composer update --prefer-lowest --prefer-stableforlowest,composer update --with-all-dependenciesfornormal.Deps ${{ matrix.deps }}for clarity.Documentation
README.md: replaced the 3.x note. New text statesmasteris under heavy 3.x development, D6/D7 has been dropped, and points to the2.xbranch for the maintenance line.