Added 'DrupalExtension' downstream smoke check job to CI.#361
Added 'DrupalExtension' downstream smoke check job to CI.#361AlexSkrypnyk merged 1 commit intomasterfrom
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
51b0797 to
2e3e4c3
Compare
622776f to
0a2c905
Compare
0a2c905 to
6d82c06
Compare
|
Code coverage (threshold: 95%) Per-class coverage |
Summary
Adds an
extensionjob to the CI workflow that runsjhedstrom/drupalextension's own PHPUnit suite against the current DrupalDriver HEAD on every PR and push tomaster. The job checks out DrupalExtension at a configurable ref, injects the local DrupalDriver source via a Composer path repository, then runs the consumer's tests - failing the build if any break. This catches driver regressions that would otherwise only surface after the downstream consumer picks up a release. Two prerequisite steps are included:pcovcoverage is enabled (DrupalExtension'sphpunit.xmlhasfailOnWarningand would fail on a missing-coverage-driver warning), and a symlink at/var/www/html/buildis created forBrowserKitFactoryTest, which hardcodes that path when calling DrupalFinder.Stack
This PR is #4 of 4 in a stacked series:
feature/driver-interface->master(Tightened 'DrupalDriverInterface' contract and 'DrupalDriver' visibility. #358)feature/field-classifier->feature/driver-interface(Added 'FieldClassifier' with nine F-row predicates and rewrote field-expansion pipeline. #359)feature/field-coverage->feature/field-classifier(Restored 'text', 'text_long', 'file', 'image' field-handler semantics and added type-coverage safety net. #360)feature/ext-smoke-ci->feature/field-coverageMerge LAST. Depends on #360 - without the field-handler fixes in that PR, DrupalExtension's PHPUnit fails because
text_long/text/fileregressions break consumer tests.Changes
extensionjob that checks out DrupalExtension and installs it with the local DrupalDriver injected via a Composer path repositorypcovcoverage driver enabled in PHP setup so DrupalExtension'sfailOnWarningdoes not abort the run/var/www/html/build->drupalextensioncheckout forBrowserKitFactoryTestDRUPALEXTENSION_REPO/DRUPALEXTENSION_REFenv vars at the top of the workflow file make the consumer target fully configurable without a code changeworkflow_dispatch:trigger added so the job can be manually re-run against a different consumer refBefore / After