Skip to content

Added 'DrupalExtension' downstream smoke check job to CI.#361

Merged
AlexSkrypnyk merged 1 commit intomasterfrom
feature/ext-smoke-ci
Apr 28, 2026
Merged

Added 'DrupalExtension' downstream smoke check job to CI.#361
AlexSkrypnyk merged 1 commit intomasterfrom
feature/ext-smoke-ci

Conversation

@AlexSkrypnyk
Copy link
Copy Markdown
Collaborator

Summary

Adds an extension job to the CI workflow that runs jhedstrom/drupalextension's own PHPUnit suite against the current DrupalDriver HEAD on every PR and push to master. The job checks out DrupalExtension at a configurable ref, injects the local DrupalDriver source via a Composer path repository, then runs the consumer's tests - failing the build if any break. This catches driver regressions that would otherwise only surface after the downstream consumer picks up a release. Two prerequisite steps are included: pcov coverage is enabled (DrupalExtension's phpunit.xml has failOnWarning and would fail on a missing-coverage-driver warning), and a symlink at /var/www/html/build is created for BrowserKitFactoryTest, which hardcodes that path when calling DrupalFinder.

Stack

This PR is #4 of 4 in a stacked series:

Merge LAST. Depends on #360 - without the field-handler fixes in that PR, DrupalExtension's PHPUnit fails because text_long/text/file regressions break consumer tests.

Changes

  • New extension job that checks out DrupalExtension and installs it with the local DrupalDriver injected via a Composer path repository
  • pcov coverage driver enabled in PHP setup so DrupalExtension's failOnWarning does not abort the run
  • Symlink step creating /var/www/html/build -> drupalextension checkout for BrowserKitFactoryTest
  • DRUPALEXTENSION_REPO / DRUPALEXTENSION_REF env vars at the top of the workflow file make the consumer target fully configurable without a code change
  • workflow_dispatch: trigger added so the job can be manually re-run against a different consumer ref

Before / After

Before:  lint  |  tests (PHP 8.2/8.3/8.4 x Drupal 10/11)
After:   lint  |  tests (PHP 8.2/8.3/8.4 x Drupal 10/11)  |  extension (smoke)

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 28, 2026

Warning

Rate limit exceeded

@AlexSkrypnyk has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 40 minutes and 27 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cbdd4ad6-662a-4934-826e-49258acefd22

📥 Commits

Reviewing files that changed from the base of the PR and between 32ca8d3 and 6d82c06.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/ext-smoke-ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/field-coverage branch from 51b0797 to 2e3e4c3 Compare April 28, 2026 08:16
@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/ext-smoke-ci branch from 622776f to 0a2c905 Compare April 28, 2026 08:18
@AlexSkrypnyk AlexSkrypnyk changed the base branch from feature/field-coverage to master April 28, 2026 08:24
@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/ext-smoke-ci branch from 0a2c905 to 6d82c06 Compare April 28, 2026 08:24
@github-actions
Copy link
Copy Markdown

Code coverage (threshold: 95%)



Code Coverage Report Summary:
  Classes: 88.46% (23/26)
  Methods: 96.11% (173/180)
  Lines:   99.00% (890/899)

Per-class coverage
Drupal\Driver\BlackboxDriver                                 100.00%
Drupal\Driver\Core\Core                                       99.38%
Drupal\Driver\Core\Field\AbstractHandler                     100.00%
Drupal\Driver\Core\Field\AddressHandler                      100.00%
Drupal\Driver\Core\Field\BooleanHandler                      100.00%
Drupal\Driver\Core\Field\DaterangeHandler                    100.00%
Drupal\Driver\Core\Field\DatetimeHandler                     100.00%
Drupal\Driver\Core\Field\DefaultHandler                      100.00%
Drupal\Driver\Core\Field\EmbridgeAssetItemHandler              0.00%
Drupal\Driver\Core\Field\EntityReferenceHandler              100.00%
Drupal\Driver\Core\Field\EntityReferenceRevisionsHandler      91.11%
Drupal\Driver\Core\Field\FieldClassifier                      94.44%
Drupal\Driver\Core\Field\FileHandler                         100.00%
Drupal\Driver\Core\Field\ImageHandler                        100.00%
Drupal\Driver\Core\Field\LinkHandler                         100.00%
Drupal\Driver\Core\Field\ListFloatHandler                      0.00%
Drupal\Driver\Core\Field\ListHandlerBase                     100.00%
Drupal\Driver\Core\Field\ListIntegerHandler                    0.00%
Drupal\Driver\Core\Field\ListStringHandler                     0.00%
Drupal\Driver\Core\Field\NameHandler                         100.00%
Drupal\Driver\Core\Field\OgStandardReferenceHandler            0.00%
Drupal\Driver\Core\Field\SupportedImageHandler               100.00%
Drupal\Driver\Core\Field\TextHandler                         100.00%
Drupal\Driver\Core\Field\TextLongHandler                     100.00%
Drupal\Driver\Core\Field\TextWithSummaryHandler              100.00%
Drupal\Driver\Core\Field\TimeHandler                         100.00%
Drupal\Driver\DrupalDriver                                   100.00%
Drupal\Driver\DrushDriver                                    100.00%
Drupal\Driver\Exception\BootstrapException                   100.00%
Drupal\Driver\Exception\Exception                            100.00%
Drupal\Driver\Exception\UnsupportedDriverActionException     100.00%

@AlexSkrypnyk AlexSkrypnyk merged commit 926dd6f into master Apr 28, 2026
13 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/ext-smoke-ci branch April 28, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant