Fixed documentation inaccuracies surfaced during v3.0.0 release review.#373
Conversation
📝 WalkthroughWalkthroughDocumentation updates across three files clarify v3.x release finalization: CONTRIBUTING.md removes outdated roadmap notes and refines test infrastructure descriptions; README.md updates version support guidance and fixes usage examples with proper EntityStub instantiation; UPGRADING.md corrects CoreInterface accessor naming. Changesv3.x Release Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Code coverage (threshold: 95%) Per-class coverage |
Summary
Documentation inaccuracies surfaced during the v3.0.0 release review are fixed across README.md, CONTRIBUTING.md, and UPGRADING.md. All changes are documentation only - no PHP was modified. The fixes bring the docs into alignment with what actually ships in v3: the
EntityStubAPI, the kernel test suite, the realcomposer testscript, stable accessor names, and the actual mix of test frameworks in use.Changes
README.md
Banner note - removed "under heavy development for version 3.x" wording and the link to the now-closed #312 epic. Replaced with a concise statement of what v3 supports (Drupal 10/11, PHP 8.2+) and a pointer to the 2.x branch for users who need it.
Quickstart example - the example used the v2
(object) [...]cast which throwsTypeErroragainst v3's typednodeCreate(EntityStubInterface $stub)signature. Updated to usenew EntityStub('node', 'article', [...])with the requiredusestatement, and demonstrated capturing the return value.CONTRIBUTING.md
"Actively working on 3.x" announcement block - removed. v3 work is complete.
"What are we testing?" section - the section previously told contributors there were no Drupal-installation tests yet, and that kernel tests were planned for v3.x. The kernel test suite (
tests/Drupal/Tests/Driver/Kernel/) ships in v3 with 14 test files. Rewrote the section to describe both unit and kernel test suites accurately, and dropped a stale "PhpSpec specs (legacy)" bullet - thespec/directory does not exist in v3. Thephpspec/prophecy-phpunitComposer dep remains, but only as a transitive runtime requirement of Drupal core'sKernelTestBase; it is not a PhpSpec BDD framework reference.Commands table -
composer testwas listed as "PHPUnit + PhpSpec" but the actualtestscript incomposer.jsonis PHPUnit only. Updated the table to matchcomposer.jsonexactly and addedcomposer test-coverage. Also dropped theXDEBUG_MODE=offprefix from the inline phpunit example.UPGRADING.md
Historical prerelease note - an intra-v3 note explained that
classifier()was renamed togetFieldClassifier()before 3.0.0-alpha1. Per project convention, docs describe what IS, not what WAS. Replaced the paragraph with a single sentence stating the current accessor name and how it fits the existing naming pattern.Before / After
README.md quickstart
Before:
After:
README.md banner
Before:
After: