feat: 문서(Document) 삭제 API 구현#22
Merged
hellonaeunkim merged 6 commits intodevfrom Mar 19, 2026
Hidden character warning
The head ref may contain hidden characters: "feat/#19_\ubb38\uc11c_\uc0ad\uc81c"
Merged
Conversation
Closed
19 tasks
oneplast
reviewed
Mar 19, 2026
documents-infrastructure/src/main/java/com/documents/repository/DocumentRepository.java
Outdated
Show resolved
Hide resolved
documents-infrastructure/src/main/java/com/documents/service/DocumentServiceImpl.java
Outdated
Show resolved
Hide resolved
documents-infrastructure/src/main/java/com/documents/service/DocumentServiceImpl.java
Outdated
Show resolved
Hide resolved
Collaborator
|
전체적으로 요구사항에 맞는 흐름으로 잘 구현된 것 같습니다. 고생 많으셨습니다! 이 부분 한 번 확인해주시고, 사실이라면 해당 부분만 픽스해주시면 될 것 같습니다. 제가 잘못 보거나 놓친 부분이 있을 수 있으니, 그런 경우 커멘트 남겨주시면 감사드리겠습니다! 추가로, 벌크 업데이트 쿼리가 실제로 1번만 나가는지 검증하는 테스트코드도 있으면 좋을 것 같습니다! |
oneplast
reviewed
Mar 19, 2026
documents-infrastructure/src/main/java/com/documents/repository/BlockRepository.java
Show resolved
Hide resolved
# Conflicts: # documents-core/src/main/java/com/documents/service/BlockService.java # documents-infrastructure/src/main/java/com/documents/service/BlockServiceImpl.java # documents-infrastructure/src/test/java/com/documents/service/BlockServiceImplTest.java
46e77cd to
54f6b35
Compare
Collaborator
|
수정 확인했습니다! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Part (해당되는 것만 체크)
#️⃣ 연관된 이슈
closes #19
🔎 작업 내용
1. 주요 변경 사항 요약
DELETE /v1/documents/{documentId})bulk update방식으로 정리하고, 서비스/WebMvc/통합 테스트를 보강했습니다.2. 상세 내용 (선택)
DELETE /v1/documents/{documentId}X-User-IdDocument.deletedAt,Document.updatedBy,updatedAt이 갱신됩니다.documents-api에 문서 삭제 엔드포인트를 추가했습니다.documents-core의DocumentService계약에 삭제 메서드를 추가했습니다.documents-infrastructure에서 문서 삭제와 블록 삭제를 하나의 트랜잭션으로 묶었습니다.@Modifying) 방식으로 처리했습니다.DOCUMENT_NOT_FOUND를 반환합니다.X-User-Id헤더가 없으면UNAUTHORIZED를 반환합니다.3. 프롬프트 경로
💬 집중 리뷰 요청
DocumentServiceImpl에서 문서 삭제 후 Block 삭제를 연계하는 책임 분리가 현재 구조에 맞는지 봐주시면 좋겠습니다.@Modifying벌크 update로 처리한 방식이 현재 구조에 맞는지 봐주시면 좋겠습니다.🧪 테스트 방법
1. 로컬 실행 방법
./gradlew :documents-api:test./gradlew :documents-infrastructure:test./gradlew :documents-boot:test2. 테스트 시나리오
DELETE /v1/documents/{documentId}호출 시 성공 응답이 반환되는지 확인DOCUMENT_NOT_FOUND응답이 반환되는지 확인DOCUMENT_NOT_FOUND응답이 반환되는지 확인X-User-Id헤더가 없으면UNAUTHORIZED응답이 반환되는지 확인✅ PR 체크리스트