Jier reogranize high prio files

[jier]

Summary

• Eliminated the legacy core.py document-role implementation (548 lines deleted); core_orchestrated.py is now the sole entry point, removing the DOCSIBLE_USE_ORCHESTRATOR feature flag entirely.
• Completed structural reorganization items A–J: complexity detection, diagram generation, formatters, validators, helpers, and legacy commands are each consolidated into purpose-built modules.
• Fixed a bug in document_collection.py where the wrong template ("standard") was selected for collection role READMEs; corrected to "standard_modular".
• Rewrote test_orchestrator_cli.sh to use the modern intent-based CLI (docsible document role, docsible analyze role, docsible validate role); deleted the now-obsolete test_implementation_comparison.sh.
• Added tests/fixtures/edge_case_role/ and 5 new pytest end-to-end tests covering block/rescue/always, include/import_role, register, retries/until, handlers with listen aliases, nested dict vars, and empty defaults.

What changed and why

A — Complexity detector relocated. defaults/detectors/complexity.py deleted. ComplexityFindings, ComplexityDetector, and the new ENTERPRISE ComplexityCategory value now live in analyzers/complexity_analyzer/defaults_detector.py. Six import sites updated.

B — Diagram generation consolidated. All diagram-related code moved into a dedicated diagrams/ module, removing scattered files from utils/.

C — Dual document-role implementation eliminated. commands/document_role/core.py (548 lines) deleted. core_orchestrated.py is now the sole implementation. DOCSIBLE_USE_ORCHESTRATOR env var removed. Three helper functions moved into core_orchestrated.py. Six import sites + init.py updated.

D–J — utils/ cleanup, formatters centralized, validators/ → validation/, help/ → helpers/, legacy docsible role isolated in commands/legacy/, phase detector merged, model colocation pattern documented.

Bug fix — document_collection.py template corrected from "standard" (broken monolithic tables) → "standard_modular" (clean modular sections).

CLI/tests — test_orchestrator_cli.sh rewritten, test_implementation_comparison.sh deleted, edge_case_role fixture + 5 new pytest end-to-end tests added.

Housekeeping — .docsible/ at project root deleted and gitignored.

Breaking changes
None. All changes are internal restructuring. No public CLI surface changed.

Test results
995 passed · 0 mypy errors · ruff clean