Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refines Chapter 4 of the JavaScript documentation by tuning wording, updating the table of contents, adjusting spacing/indentation, and replacing PNG images with WebP.
- Adjusted TOC entry for “if 文” to match heading format
- Clarified examples around quadratic discriminant with improved phrasing
- Converted images from
.pngto.webpand removed old sources
| しかし階層が深くなると複雑になり、読みづらくなるので注意が必要です。 | ||
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
The second image filename has a typo ('consitional-operator-2.webp'); it should be 'conditional-operator-2.webp' to fix the broken link.
|  | |
|  |
| | `厳密等価` | `a === b` | | ||
| | `厳密不等価` | `a !== b` | | ||
| | `超過/より大きい` | `a > b` | | ||
| | `超過 / ~ より大きい` | `a > b` | |
There was a problem hiding this comment.
[nitpick] Remove the stray tilde '~' in the label to match the pattern of other entries (e.g., change '超過 / ~ より大きい' to '超過 / より大きい').
| | `超過 / ~ より大きい` | `a > b` | | |
| | `超過 / より大きい` | `a > b` | |
| | `超過 / ~ より大きい` | `a > b` | | ||
| | `以上` | `a >= b` | | ||
| | `未満/より小さい` | `a < b` | | ||
| | `未満 / ~ より小さい` | `a < b` | |
There was a problem hiding this comment.
[nitpick] Remove the stray tilde '~' in the label to match the pattern of other entries (e.g., change '未満 / ~ より小さい' to '未満 / より小さい').
| - 正の値 のとき 実数解をもつ | ||
| - 0 のとき 重解をもつ | ||
| - 負の値 のとき 虚数解をもつ | ||
|
|
||
| - 正の値 → `value > 0` | ||
| - 0 → `value === 0` | ||
| - 負の値 → `value < 0` | ||
| ここで$D$の結果を `value` という変数に置き換えたとき、それぞれの条件は比較演算子を用いて以下のように表せます。 | ||
|
|
||
| JSではこのようにして値の大小や等価かどうかを比較できます。 | ||
| 以下に比較演算子の表を示します。 | ||
| - 正の値 → `value > 0` | ||
| - 0 → `value === 0` | ||
| - 負の値 → `value < 0` | ||
|
|
There was a problem hiding this comment.
[nitpick] The discriminant conditions are listed twice (once as descriptive text in lines 300–302 and again as code conditions in lines 306–308). Consider consolidating into a single table or combined list for clarity.
There was a problem hiding this comment.
「変数に置き換えたとき」の表現として二重になっているだけなので許容としたい
haruto17
force-pushed
the
main
branch
2 times, most recently
from
67ca9ab to
ad809c0
Compare
|
マージします🙏 |
変更点
確認したこと