build(cli): expose adbc feature flag#1
Draft
dataders wants to merge 1 commit intojimhester:pr1-adbc-readerfrom
Draft
build(cli): expose adbc feature flag#1dataders wants to merge 1 commit intojimhester:pr1-adbc-readerfrom
dataders wants to merge 1 commit intojimhester:pr1-adbc-readerfrom
Conversation
Forward the CLI crate's optional adbc feature to ggsql/adbc so the CLI can be built against the ADBC reader from PR posit-dev#422 without adding URI, Snowflake, or dbt profile plumbing here. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on
pr1-adbc-reader, the branch behind posit-dev#422. This follow-up only forwards the CLI crate's optionaladbcfeature toggsql/adbc, soggsql-clican be built against the ADBC reader from PR1.This intentionally does not add:
~/.dbt/profiles.ymlparsingThe linked meta-issue comment defers generic
adbc://URI design for CLI/Jupyter to a later discussion, so this stays at the feature-gate plumbing layer.Validation
cargo check -p ggsql-cli --no-default-features --features "adbc vegalite"git diff --checkRelated