Skip to content

Improve libvroom type inference (#49)#55

Merged
jimhester merged 5 commits intomainfrom
issue-49-libvroom-improve-type-inference-t-f-logical-inf
Feb 6, 2026
Merged

Improve libvroom type inference (#49)#55
jimhester merged 5 commits intomainfrom
issue-49-libvroom-improve-type-inference-t-f-logical-inf

Conversation

@jimhester
Copy link
Owner

Summary

  • Recognize T/F/t/f as logical values in type inference and all bool parsers
  • Respect trim_ws option during type guessing (whitespace no longer stripped when trim_ws=FALSE)
  • Recognize Inf/+Inf/-Inf as doubles in type inference and all float64 parsers
  • Forward guess_max parameter from R to libvroom's sample_rows for type inference

Closes #49

Test Plan

  • devtools::test(filter = "logical") — 14/14 pass (T/F/t/f tests unskipped)
  • devtools::test(filter = "dbl") — 12/12 pass (Inf test unskipped)
  • devtools::test(filter = "vroom") — 552/552 pass (guess_max and trim_ws tests unskipped)
  • devtools::test() — full suite: 920 pass, 0 fail
  • air format . — clean

jimhester and others added 5 commits February 6, 2026 10:32
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jimhester jimhester merged commit 3635488 into main Feb 6, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

libvroom: Improve type inference (T/F logical, Inf/-Inf double, guess_max, trim_ws)

1 participant