Refactor RTSP server to use hosted service pattern#5
Merged
jimm98y merged 1 commit intojimm98y:mainfrom Jan 19, 2025
Merged
Conversation
- Updated `Program.cs` to implement `Host` and `IHostedService`, moving RTSP server initialization to `RTSPServerWorker`. - Changed project file to use `Microsoft.NET.Sdk.Worker` and updated package references. - Created `RTSPServerWorker.cs` to manage the RTSP server lifecycle, including configuration and logging. - Modified `appsettings.json` to nest RTSP server settings under `RTSPServerApp` and added a `Logging` section.
Owner
|
Looks nice, thank you very much! Originally, the sample server was meant to be used just as a "sample code" and not really meant for production use (unlike the library), but I love how this makes it much more usable out of the box. |
Contributor
Author
|
It's still not production ready, but useful to see what's going on, including logging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Program.csto implementHostandIHostedService, moving RTSP server initialization toRTSPServerWorker.Microsoft.NET.Sdk.Workerand updated package references.RTSPServerWorker.csto manage the RTSP server lifecycle, including configuration and logging.appsettings.jsonto nest RTSP server settings underRTSPServerAppand added aLoggingsection.This helps to see the logs produced.