Add support for RTSPS to RTSPClient#7
Merged
jimm98y merged 2 commits intojimm98y:mainfrom Feb 2, 2025
Merged
Conversation
Used `Rtsp.RtspUtils.CreateRtspTransportFromUrl(_uri)` to create RTSP transport.
jimm98y
approved these changes
Feb 2, 2025
Owner
jimm98y
left a comment
There was a problem hiding this comment.
Looks good, I've just fixed the "http" transport as the original one does not pass the credentials down to the transport element. I've also exposed the certificate validation callback so that users can use it with self-signed certificates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
Rtsp.RtspUtils.CreateRtspTransportFromUrl(_uri)to create RTSP transport.