added "muteunmute" command to toggle mute state #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I'm not convinced about this naming scheme. "togglemute" might be more intuitive. Even better would perhaps have been to use: Or something, but unfortunately we now already has mute/unmute :). Would still prefer "togglemute" over "muteunmute". |
Owner
|
I assume this is because you are mapping this to a single button somwhere? |
Contributor
Author
|
correct, using bettertouchtools. I copied the playpause name scheme. |
mattywong
commented
Dec 22, 2016
Contributor
Author
mattywong
left a comment
mattywong
left a comment
There was a problem hiding this comment.
change muteunmute to togglemute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.