Sc 20043 self hosted runners customer scripts part2#13
Conversation
|
This pull request has been linked to Shortcut Story #20043: self-hosted-runners - customer scripts. |
| ### Running on CentOS | ||
|
|
||
| ```shell | ||
| make self-hosted-runner centos runner_token=<runner-token> github_org=<github-organization> jit_repo=<jit-repo-name> |
There was a problem hiding this comment.
why do we need the jit centralize repo name? isn't that relates to self hosted runners that are configured in repo level instead of organization level?
There was a problem hiding this comment.
If so this parameter should be optional and an explanation should be added about configuring the runner to the organization or a specific repo
| # Check if script is run as root | ||
| if [ "$EUID" -eq 0 ]; then | ||
| echo "Please run this script as a non-root user." | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
no need for that as we added it in the make file
| @@ -0,0 +1,68 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
The name of this scrip should be changed to setup-rootless-docker; hence we don't actually setup the runner here, only installing rootless docker, same to the centos one
| sudo yum install -y jq | ||
| chmod +x $(SELF_HOSTED_DOCKER_CENTOS_SCRIPT) | ||
| ./$(SELF_HOSTED_DOCKER_CENTOS_SCRIPT) | ||
| else ifeq ($(filter ubuntu,$(MAKECMDGOALS)),ubuntu) |
There was a problem hiding this comment.
are we sure we dont need jq installation at ubuntu?
There was a problem hiding this comment.
works with clean ubuntu ami on ec2
| `https://github.com/<your-github-org-name>/jit/settings/actions/runners` | ||
|
|
||
| #### Running on CentOS | ||
| ### Running on CentOS |
There was a problem hiding this comment.
We need to add pre-requisit step to install git, and make packages before running this command in both OSs
There was a problem hiding this comment.
it's in the readme in a lower part. moved it up..
that's from the readme:
Prerequisites
- Python 3.x
- Git
- make
To make sure you have all you can run this command:
Centos distro
sudo yum install -y git make && git clone https://github.com/jitsecurity/jit-customer-scripts.git && cd jit-customer-scriptsUbuntu distro
sudo apt install -y git make && git clone https://github.com/jitsecurity/jit-customer-scripts.git && cd jit-customer-scriptsMac
brew install git make && git clone https://github.com/jitsecurity/jit-customer-scripts.git && cd jit-customer-scripts
k-shlomi
deleted the
sc-20043-self-hosted-runners-customer-scripts-part2
branch
2 participants
No description provided.