Skip to content

Add helm chart to rotate registry creds#29

Merged
meshiyo merged 4 commits intomainfrom
sc-27540-helm-chart-to-rotate-ecr-secrets
Oct 21, 2024
Merged

Add helm chart to rotate registry creds#29
meshiyo merged 4 commits intomainfrom
sc-27540-helm-chart-to-rotate-ecr-secrets

Conversation

@arielbeckjit
Copy link
Copy Markdown
Contributor

A helm chart that refreshes our registry creds

Copy link
Copy Markdown

@jit-ci jit-ci Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Jit has detected 1 important finding in this PR that you should review.
The finding is detailed below as a comment.
It’s highly recommended that you fix this security issue before merge.

@@ -0,0 +1,86 @@
apiVersion: v1
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security control: Iac Misconfig Detection Kubernetes

Type: Applications Credentials In Configuration Files

Description: More details in the link below

Severity: HIGH

Learn more about this issue


Jit Bot commands and options (e.g., ignore issue)

You can trigger Jit actions by commenting on this PR review:

  • #jit_ignore_fp Ignore and mark this specific single instance of finding as “False Positive”
  • #jit_ignore_accept Ignore and mark this specific single instance of finding as “Accept Risk”
  • #jit_ignore_type_in_file Ignore any finding of type "Applications credentials in configuration files" in src/kubernetes/jit_ecr/templates/script-configmap.yaml; future occurrences will also be ignored.
  • #jit_undo_ignore Undo ignore command

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#jit_ignore_fp

Copy link
Copy Markdown

@jit-ci jit-ci Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Jit has detected 1 important finding in this PR that you should review.
The finding is detailed as a comment.
It’s highly recommended that you fix this security issue before merge.

Until now, you ignored/fixed 1 finding.

@@ -0,0 +1,86 @@
apiVersion: v1
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security control: Iac Misconfig Detection Kubernetes

Type: Applications Credentials In Configuration Files

Description: More details in the link below

Severity: HIGH

Learn more about this issue


Jit Bot commands and options (e.g., ignore issue)

You can trigger Jit actions by commenting on this PR review:

  • #jit_ignore_fp Ignore and mark this specific single instance of finding as “False Positive”
  • #jit_ignore_accept Ignore and mark this specific single instance of finding as “Accept Risk”
  • #jit_ignore_type_in_file Ignore any finding of type "Applications credentials in configuration files" in src/kubernetes/jit_ecr/templates/script-configmap.yaml; future occurrences will also be ignored.
  • #jit_undo_ignore Undo ignore command

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#jit_ignore_fp

@meshiyo meshiyo merged commit 67bcc0d into main Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants