Skip to content

Comments

Add ToolTip to the chat message display name and enclose the content in span element instead of div element.#15733

Closed
wilsonfurtado2000 wants to merge 6 commits intojitsi:masterfrom
wilsonfurtado2000:wilson-jitsi-15
Closed

Add ToolTip to the chat message display name and enclose the content in span element instead of div element.#15733
wilsonfurtado2000 wants to merge 6 commits intojitsi:masterfrom
wilsonfurtado2000:wilson-jitsi-15

Conversation

@wilsonfurtado2000
Copy link
Contributor

@wilsonfurtado2000 wilsonfurtado2000 commented Mar 9, 2025

This PR adds the Tooltip to the chat message displayName when text is elided, previously the element was wrapped in a div element which is a bad option as the css logic was added to the div, this PR also encloses the displayName in a span and adds the tooltip.

After:
https://github.com/user-attachments/assets/c499ceba-b01e-40a9-bbcc-079501ce1be6

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@saghul saghul requested review from Calinteodor and mihhu March 9, 2025 14:23
@wilsonfurtado2000
Copy link
Contributor Author

@Calinteodor @mihhu could you please review this PR ?

@Calinteodor
Copy link
Contributor

Jenkins test this please.

@wilsonfurtado2000
Copy link
Contributor Author

Jenkins test this please.

I think the failing Jenkins check is unrelated to this change ?

@github-actions
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 11, 2025
@damencho
Copy link
Member

Jenkins test this please

@@ -228,7 +245,25 @@ const ChatMessage = ({
<div
aria-hidden = { true }
Copy link
Contributor

@Calinteodor Calinteodor Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. From the screen rec that you sent us, the tooltip text looks kind of off in it's container. Maybe title attribute could be a better alternative. What do you think?

@github-actions github-actions bot removed the stale label Jun 12, 2025
@github-actions
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 11, 2025
@github-actions github-actions bot closed this Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants