Add ToolTip to the chat message display name and enclose the content in span element instead of div element.#15733
Conversation
|
Hi, thanks for your contribution! |
|
@Calinteodor @mihhu could you please review this PR ? |
|
Jenkins test this please. |
I think the failing Jenkins check is unrelated to this change ? |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Jenkins test this please |
| @@ -228,7 +245,25 @@ const ChatMessage = ({ | |||
| <div | |||
| aria-hidden = { true } | |||
There was a problem hiding this comment.
Thank you for your contribution. From the screen rec that you sent us, the tooltip text looks kind of off in it's container. Maybe title attribute could be a better alternative. What do you think?
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This PR adds the Tooltip to the chat message displayName when text is elided, previously the element was wrapped in a div element which is a bad option as the css logic was added to the div, this PR also encloses the displayName in a span and adds the tooltip.
After:
https://github.com/user-attachments/assets/c499ceba-b01e-40a9-bbcc-079501ce1be6