Skip to content

fix: skip review on merge commits#3

Merged
vklimontovich merged 1 commit intomainfrom
fix/skip-merge-commits
Apr 20, 2026
Merged

fix: skip review on merge commits#3
vklimontovich merged 1 commit intomainfrom
fix/skip-merge-commits

Conversation

@vklimontovich
Copy link
Copy Markdown
Contributor

The push: branches: [main] trigger fires on merge commits when PRs are merged.
The existing skip logic checks commits/{sha}/pulls but GitHub doesn't associate
merge commits with PRs via that API, so the check returns 0 and the review runs
redundantly.

Fix: check parent count first. Merge commits always have 2 parents — if
parents | length > 1, skip immediately before the PR association check.

@vklimontovich
Copy link
Copy Markdown
Contributor Author

Looks good

@vklimontovich vklimontovich merged commit 666fdb4 into main Apr 20, 2026
1 check passed
Copy link
Copy Markdown

@jitsu-code-review jitsu-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: I reviewed the changes in this PR and found no actionable bugs, security issues, or correctness regressions. The merge-commit skip on push events is scoped and behaves consistently with the existing target-resolution flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant