fix(ai-review): only request changes for critical findings#9
Merged
Conversation
Raise the bar for the REQUEST_CHANGES verdict so it fires only on new, critical issues — real bugs, security holes, data loss, user-visible regressions. Non-critical and uncertain findings now post as COMMENT inline comments instead, so false positives no longer block PRs.
![jitsu-code-review[bot]](https://avatars.githubusercontent.com/in/3391383?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The AI reviewer sometimes flags a non-issue (or a finding it is not confident about) and still submits
REQUEST_CHANGES, blocking the PR.Change
Raises the bar for the
REQUEST_CHANGESverdict in the Codex prompt:REQUEST_CHANGESfires only for a new, critical issue — never for non-critical or uncertain findings, regardless of count.COMMENTinline comments (visible, non-blocking).APPROVEstill clears a priorREQUEST_CHANGESonce the critical issue is resolved, even if non-critical comments remain — avoids wedging a branch behind a stale block.