feat: per-event user override in analytics().sendEvent()#43
Merged
Conversation
sendEvent now accepts an optional `user` (UserContext) that identifies the event explicitly, overriding callbacks.getUser for that event. This covers server events whose subject isn't the request's session user — e.g. an email recipient resolved from a tracking link — so they land as real identity (userId/traits) instead of plain props.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
analytics().sendEvent()gains an optionaluser:When provided, it sets the event's
userContextdirectly, overridingcallbacks.getUserfor that one event.Why
getUserderives identity from the request (cookie/session). Some server events have a subject that isn't the requester — e.g. an email pixel/click where the recipient is encoded in the link (?e=). There was no way to attach that identity, so it could only go inprops(not the identity columns / no identify). This adds a per-event override for exactly those cases.Testing
typecheck + all tests pass.