templates: add commonly used trailers #6261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glehmann
changed the title
glehmann
force-pushed
the
glehmann/xlutzwvxsvlm
branch
12 times, most recently
from
d554b04 to
90d01d3
Compare
glehmann
force-pushed
the
glehmann/xlutzwvxsvlm
branch
5 times, most recently
from
03d9d47 to
0f3f804
Compare
yuja
reviewed
Apr 14, 2025
glehmann
force-pushed
the
glehmann/xlutzwvxsvlm
branch
from
0f3f804 to
e605e13
Compare
yuja
approved these changes
Apr 15, 2025
namely Signed-off-by and Change-Id
`format_signed_off_by_trailer` will be formatted properly if the author
name is not set, but will contain the email placeholder if the author
email is not set, as I haven't found a way to make the template
generation fail.
`format_gerrit_change_id_trailer` is based on jj's change id, but it
needed to be padded to reach 40 characters. Zero-padding is kind of
boring so I've used `6a6a6964`, the hexadecimal representation of `jjid`
in ascii.
Because the trailer value runs up to the end of the line, they are
all terminated with a new line. This way it's also convenient to
define these trailers in the `commit_trailers` template:
[templates]
commit_trailers = '''
format_signed_off_by_trailer(self)
++ format_gerrit_change_id_trailer(self)
'''
glehmann
force-pushed
the
glehmann/xlutzwvxsvlm
branch
from
e605e13 to
d9f17cf
Compare
Contributor
Author
|
@yuja Thank you for your comprehensive and kind reviews 👍 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for DCO Sign Off and Gerrit Change Id
this is based on #6088
Checklist
If applicable:
I have updatedCHANGELOG.mdI have updated the config schema (cli/src/config-schema.json)