Skip to content

Conversation

@glehmann
Copy link
Contributor

@glehmann glehmann commented Apr 5, 2025

trailer support in the commit command

based on #6088

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@glehmann glehmann requested a review from a team as a code owner April 5, 2025 15:35
@glehmann glehmann force-pushed the glehmann/swrqqomovrzr branch 12 times, most recently from d446c52 to 4285e43 Compare April 10, 2025 20:28
@glehmann glehmann force-pushed the glehmann/swrqqomovrzr branch 6 times, most recently from 6394bbc to 55d5cfd Compare April 13, 2025 20:53
@glehmann glehmann force-pushed the glehmann/swrqqomovrzr branch 3 times, most recently from 7865e8c to 0c555db Compare April 15, 2025 21:38
@glehmann
Copy link
Contributor Author

I've tried to keep the trailers PR parallel, but that was becoming complicated to deal with the combined changelog entry.
I hope you don't mind for the review!

Copy link
Contributor

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to keep the trailers PR parallel, but that was becoming complicated to deal with the combined changelog entry.

Feel free to combine them into single PR. I don't think there will be many review rounds (unlike the core implementation PR.)

Thanks.

@glehmann glehmann force-pushed the glehmann/swrqqomovrzr branch from 0c555db to 34e8ff9 Compare April 16, 2025 14:10
@glehmann glehmann added this pull request to the merge queue Apr 16, 2025
Merged via the queue into jj-vcs:main with commit 5f7159d Apr 16, 2025
28 checks passed
@glehmann glehmann deleted the glehmann/swrqqomovrzr branch April 16, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants