Skip to content

Conversation

@cenviity
Copy link
Member

  • Use jq -s to read the entire input (could be several arrays due to GitHub API pagination) before running the filter just once.
  • Deduplicate by .author.login in case a person with the same GitHub username has commits under different names within a release.
  • Use string interpolation to format each line.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added/updated tests to cover my changes

@cenviity cenviity requested a review from a team as a code owner May 22, 2025 05:30
@cenviity cenviity force-pushed the push-mmvkvwnmkvrt branch 4 times, most recently from 8c826f1 to a15bfa6 Compare May 26, 2025 07:01
- Use `jq -s` to read the entire input (could be several arrays due to GitHub API
  pagination) before running the filter just once.
- Deduplicate by `.author.login` in case a person with the same GitHub username has
  commits under different names within a release.
- Use string interpolation to format each line.
@cenviity cenviity force-pushed the push-mmvkvwnmkvrt branch from a15bfa6 to e164fa4 Compare May 28, 2025 00:35
Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't bothered to set up the authentication for gh api so I'll just trust that this what it's supposed to. Thanks!

@cenviity cenviity added this pull request to the merge queue May 28, 2025
Merged via the queue into jj-vcs:main with commit fce53da May 28, 2025
27 checks passed
@cenviity cenviity deleted the push-mmvkvwnmkvrt branch May 28, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants