Skip to content

Update taskrsrc.py#10

Merged
jjCode01 merged 2 commits intojjCode01:mainfrom
michaelrussell4:patch-1
Dec 16, 2024
Merged

Update taskrsrc.py#10
jjCode01 merged 2 commits intojjCode01:mainfrom
michaelrussell4:patch-1

Conversation

@michaelrussell4
Copy link
Copy Markdown
Contributor

Changed target_lag_drtn_hr_cnt from int to float.

Addressing issue #9

Changed target_lag_drtn_hr_cnt from `int` to `float`.
@michaelrussell4
Copy link
Copy Markdown
Contributor Author

This allows the target_lag_drtn_hr_cnt field from the TASKRSRC table to be a float.

Copy link
Copy Markdown
Owner

@jjCode01 jjCode01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to: self.target_lag_drtn_hr_cnt: float = float(data["target_lag_drtn_hr_cnt"].replace(",", ".")).
Some countries use a coma rather than a dot in their floats.

Comment thread xerparser/schemas/taskrsrc.py Outdated
Per suggestion, added comma replacement.
@michaelrussell4
Copy link
Copy Markdown
Contributor Author

Change to: self.target_lag_drtn_hr_cnt: float = float(data["target_lag_drtn_hr_cnt"].replace(",", ".")). Some countries use a coma rather than a dot in their floats.

Great, sounds good. I made the change.

@jjCode01 jjCode01 merged commit 2c7215f into jjCode01:main Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants