Update taskrsrc.py#10
Merged
jjCode01 merged 2 commits intojjCode01:mainfrom Dec 16, 2024
Merged
Conversation
Changed target_lag_drtn_hr_cnt from `int` to `float`.
Contributor
Author
|
This allows the |
jjCode01
requested changes
Dec 16, 2024
Owner
jjCode01
left a comment
There was a problem hiding this comment.
Change to: self.target_lag_drtn_hr_cnt: float = float(data["target_lag_drtn_hr_cnt"].replace(",", ".")).
Some countries use a coma rather than a dot in their floats.
Per suggestion, added comma replacement.
Contributor
Author
Great, sounds good. I made the change. |
jjCode01
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed target_lag_drtn_hr_cnt from
inttofloat.Addressing issue #9