Fix service worker performance and offline mode#137
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to improve Blazor WebAssembly service worker performance and strengthen offline behavior, with an additional build-time validation that index.html is included in the published service worker asset manifest.
Changes:
- Optimize service worker asset URL lookups and adjust fetch strategy to prefer network-first.
- Parallelize “response cleaning” during service worker install.
- Add a publish-output validation script and wire it into
eng/build.sh; tweak index.html generation to ensure it’s included inservice-worker-assets.js.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/WebAssembly/wwwroot/service-worker.published.js | Switches to a Set for manifest URL checks, parallelizes install-time cache response cleaning, and changes fetch strategy. |
| eng/check-publish-output.cs | New script to validate index.html appears in service-worker-assets.js under the publish output. |
| eng/build.sh | Runs the new publish-output validation after publishing. |
| eng/IndexHtmlGeneration.targets | Changes index.html content inclusion to use a relative path so it can be picked up by static web assets/service worker manifest generation. |
| .config/dotnet-tools.json | Bumps dotnet-serve tool version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.