Implement account key rollover validation.#40
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds RFC 8555 §7.3.5-compliant ACME account key rollover handling by updating both server-side validation and the conformance test suite to reflect the correct outer/inner JWS semantics.
Changes:
- Update ACME conformance steps and keyChange request construction to use outer
kid(old key) and innerjwk(new key). - Adjust request validation rules so
KeyChangeis treated as a Kid-signed (existing account) endpoint. - Update
/key-changeendpoint logic to resolve the account from the outerkid, enforce inner-JWS constraints (no nonce,jwkpresent,kidabsent), and validateoldKeyagainst the account’s current key.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/opencertserver.certserver.tests/StepDefinitions/AcmeConformance.cs | Updates keyChange conformance assertions and request builder to match RFC 8555 outer/inner JWS rules. |
| tests/opencertserver.certserver.tests/Features/AcmeConformance.feature | Updates scenario text to reflect correct outer/inner signing keys for key rollover. |
| tests/opencertserver.certserver.tests/Features/AcmeConformance.feature.cs | Regenerates bindings to match updated feature step text. |
| src/opencertserver.acme.server/RequestServices/DefaultRequestValidationService.cs | Treats KeyChange as a Kid-only endpoint; removes now-incorrect keyChange JWK-only rule. |
| src/opencertserver.acme.server/Endpoints/AccountEndpoints.cs | Implements keyChange outer/inner validation and verifies oldKey matches the account’s current key. |
Files not reviewed (1)
- tests/opencertserver.certserver.tests/Features/AcmeConformance.feature.cs: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot stopped work on behalf of
jjrdk due to an error
April 11, 2026 21:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for account key rollover.