Fix multipart response for server-keygen.#51
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the EST /serverkeygen multipart response so clients/tests can reliably parse it as multipart content (including the required boundary parameter).
Changes:
- Update
ServerKeyGenHandlerto emit the multipart response usingMultipartContent.Headers.ContentType(includes boundary) viaResults.Stream. - Update conformance tests to parse the response body as multipart and validate per-part content types.
- Remove the now-unneeded
MultipartContentResultimplementation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/opencertserver.certserver.tests/StepDefinitions/EstConformance.cs | Switches validation from raw text search to multipart parsing for server-keygen responses. |
| src/opencertserver.est.server/Handlers/ServerKeyGenHandler.cs | Streams MultipartContent with a Content-Type header that includes the boundary parameter. |
| src/opencertserver.est.server/Response/MultipartContentResult.cs | Deletes the custom IResult previously used to write multipart responses. |
…rmance.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…rmance.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix server-keygen response for multipart content